chore(logging): Add entry's timestamp when rejected with too far behind
#12933
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind`
Ingester uses `max_sample_age/2` to reject out-of-order ingestion in Loki. More details about how it works are here and here.
But when it is rejected, currently we print log line like this on ingester.
```
entry too far behind, oldest acceptable timestamp is: 2024-05-07T10:25:30Z
```
Problem is it doesn't print the original timestamp of the log entry itself. So hard to interpret sometime.
This PR fixes it. Now it looks something like this.
```
entry too far behind, entry timestamp is: 2024-05-05T10:25:30Z, oldest acceptable timestamp is: 2024-05-07T10:25:30Z
```
Also, another thing, now it is consistent with how error we return to client when we reject it.
```
entry with timestamp 2024-05-06 15:58:50 +0000 UTC ignored, reason: 'entry too far behind, oldest acceptable timestamp is: 2024-05-07T10:25:30Z',
user 'fake', total ignored: 1 out of 2 for stream: {app="webserver1", host="localhost", service_name="webserver1"}
```
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
cstyan
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingester uses
max_sample_age/2to reject out-of-order ingestion in Loki. More details about how it works are here and here.But when it is rejected, currently we print log line like this on ingester.
Problem is it doesn't print the original timestamp of the log entry itself. So hard to interpret sometime.
This PR fixes it. Now it looks something like this.
Also, another thing, now it is consistent with how Loki return the error to the client when it rejects it.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR