Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm) Add capability to ignore the gateway service by the serviceMonitor #12909

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

winem
Copy link

@winem winem commented May 7, 2024

What this PR does / why we need it:
This PR sets per default the label prometheus.io/scrape=false to the gateway service.

This causes the gateway service not to be treated as a Prometheus scrape target and fixes alerts that the target is down and can't be scraped. This is useful because the nginx does not provide any metrics in the default configuration.

Users could either add the label manually or we set it per default. With this PR I would pitch the 2nd option so that users don't have to investigate the alerts caused by a default loki deployment via helm.

Which issue(s) this PR fixes:
Could not find any related issue and experienced the issue by myself when switching from the loki-distributed to the loki chart.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants