Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest browser v1.5.1 #3728

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Update to the latest browser v1.5.1 #3728

merged 1 commit into from
Apr 30, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Apr 30, 2024

What?

Update to the latest version of the browser module (v1.5.1).

Why?

It contains a fix which the community have requested.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

grafana/xk6-browser#1144

@ankur22 ankur22 requested a review from a team as a code owner April 30, 2024 13:55
@ankur22 ankur22 requested review from codebien and joanlopez and removed request for a team April 30, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.76%. Comparing base (ace4bb4) to head (a2d5908).

❗ Current head a2d5908 differs from pull request most recent head 61d4820. Consider uploading reports for the commit 61d4820 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3728      +/-   ##
==========================================
- Coverage   70.87%   70.76%   -0.11%     
==========================================
  Files         289      287       -2     
  Lines       21164    21159       -5     
==========================================
- Hits        15000    14974      -26     
- Misses       5208     5222      +14     
- Partials      956      963       +7     
Flag Coverage Δ
ubuntu 70.76% <ø> (-0.04%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien removed the request for review from joanlopez April 30, 2024 14:09
@ankur22 ankur22 merged commit 633d338 into master Apr 30, 2024
22 checks passed
@ankur22 ankur22 deleted the update/browser-1.5.1 branch April 30, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants