Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for release issue's template #3727

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

codebien
Copy link
Collaborator

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@codebien codebien mentioned this pull request Apr 30, 2024
25 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (3431d7d) to head (0b6173e).
Report is 6 commits behind head on master.

❗ Current head 0b6173e differs from pull request most recent head 56597d7. Consider uploading reports for the commit 56597d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3727      +/-   ##
==========================================
- Coverage   70.86%   70.85%   -0.01%     
==========================================
  Files         289      289              
  Lines       21164    21159       -5     
==========================================
- Hits        14998    14993       -5     
  Misses       5209     5209              
  Partials      957      957              
Flag Coverage Δ
ubuntu 70.80% <ø> (+0.02%) ⬆️
windows 70.70% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien mentioned this pull request Apr 30, 2024
@codebien codebien marked this pull request as ready for review May 13, 2024 13:14
@codebien codebien requested a review from a team as a code owner May 13, 2024 13:14
@codebien codebien requested review from oleiade and olegbespalov and removed request for a team May 13, 2024 13:14
@codebien codebien self-assigned this May 13, 2024
@codebien codebien merged commit 153e0e5 into master May 14, 2024
22 checks passed
@codebien codebien deleted the imprv/release-issue-templ branch May 14, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants