Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed CI job (Homebrew) #3684

Merged
merged 1 commit into from Apr 16, 2024

Conversation

joanlopez
Copy link
Contributor

What?

It removes the (already commented out) publish-macos CI job that was originally added to automate k6 releases publication to Homebrew.

Why?

Because it's no longer needed, as now Homebrew has a recurrent (every 3h) CI job that goes over all the Homebrew projects and checks for updates.

Look at this PR, as an example, from the latest k6 release (v0.50.0).

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #1998

@joanlopez joanlopez added the ci label Apr 10, 2024
@joanlopez joanlopez self-assigned this Apr 10, 2024
@joanlopez joanlopez requested a review from a team as a code owner April 10, 2024 15:08
@joanlopez joanlopez requested review from mstoykov and olegbespalov and removed request for a team April 10, 2024 15:08
@joanlopez joanlopez merged commit 144209f into grafana:master Apr 16, 2024
23 of 24 checks passed
@mstoykov mstoykov added this to the v0.51.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating Homebrew version bump PR in CI
3 participants