Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added summary generated event #3682

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

ameetpal
Copy link
Contributor

@ameetpal ameetpal commented Apr 10, 2024

What?

Emitting Summary Generated event

Why?

#3683

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@ameetpal ameetpal requested a review from a team as a code owner April 10, 2024 10:40
@ameetpal ameetpal requested review from oleiade and olegbespalov and removed request for a team April 10, 2024 10:40
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

@oleiade
Copy link
Member

oleiade commented Apr 17, 2024

Hey @ameetpal 👋🏻

First and foremost, thanks a lot for taking the time and putting the effort into contributing to k6, we very much appreciate it 🙇🏻

We had a bit of a delay in our response as the team needed to discuss and synchronize on this topic. We reached the conclusion that we're rather open to reviewing and potentially merging this, with the specific caveat that we consider this internal event system experimental, and we might change/break it and its API in the future. Thus, if that's an acceptable prerequisite for you, we'll go ahead with the review indeed 👍🏻

PS: through our discussions, we outlined that this could potentially be a topic/issue/PR that you would be interested in @pablochacin 👀

Copy link
Collaborator

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ameetpal

Thanks for your contribution!

From the code standpoint, it looks good. It could be merged. However, as @oleiade mentioned, we do consider this events API as experimental, and it could be changed in the following releases.

@ameetpal
Copy link
Contributor Author

Hi @oleiade , @olegbespalov , we are fine with the condition and we can go ahead and merge this

@oleiade oleiade merged commit eec9105 into grafana:master Apr 25, 2024
21 checks passed
@olegbespalov olegbespalov added this to the v0.51.0 milestone Apr 25, 2024
@ameetpal ameetpal mentioned this pull request May 2, 2024
5 tasks
olegbespalov added a commit that referenced this pull request May 9, 2024
olegbespalov added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants