Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate timeUnit in ramping-arrival-rate #3658

Merged
merged 1 commit into from Mar 21, 2024
Merged

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Mar 21, 2024

What?

Validate timeUnit in ramping-arrival-rate isn't 0 apart from not being negative.

Why?

Previous to this negative time units will error but 0 timeunit will panic.

This was fixed in constant-arrival-rate long ago, but nobody checked ramping-arrival-rate.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Previous to this negative time units will error but 0 timeunit will
panic.

This was fixed in constant-arrival-rate long ago, but nobody checked
ramping-arrival-rate.
@mstoykov mstoykov added the bug label Mar 21, 2024
@mstoykov mstoykov added this to the v0.50.0 milestone Mar 21, 2024
@mstoykov mstoykov requested a review from a team as a code owner March 21, 2024 08:44
@mstoykov mstoykov requested review from codebien and joanlopez and removed request for a team March 21, 2024 08:44
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (fc60f4d) to head (c4077e6).

❗ Current head c4077e6 differs from pull request most recent head e59a652. Consider uploading reports for the commit e59a652 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3658      +/-   ##
==========================================
+ Coverage   73.57%   73.59%   +0.01%     
==========================================
  Files         277      277              
  Lines       20247    20247              
==========================================
+ Hits        14897    14901       +4     
+ Misses       4402     4398       -4     
  Partials      948      948              
Flag Coverage Δ
macos 73.49% <100.00%> (?)
ubuntu 73.51% <100.00%> (+<0.01%) ⬆️
windows 73.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 0af62a2 into master Mar 21, 2024
24 checks passed
@mstoykov mstoykov deleted the timeUnitSanitzation branch March 21, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants