Introduce execution.Controller with a local no-op implementation
#3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3204 +/- ##
==========================================
- Coverage 73.19% 73.16% -0.03%
==========================================
Files 267 261 -6
Lines 20076 19910 -166
==========================================
- Hits 14694 14567 -127
+ Misses 4468 4413 -55
- Partials 914 930 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
na--
force-pushed
the
local-execution-controller
branch
from
9a913cd
to
74dda8c
Compare
This was referenced Jul 19, 2023
na--
force-pushed
the
local-execution-controller
branch
from
9f64a28
to
74dda8c
Compare
mstoykov
previously approved these changes
Dec 13, 2023
na--
force-pushed
the
local-execution-controller
branch
from
6254df9
to
fd81209
Compare
|
Applied PR review suggestion and rebased on top of the latest |
This doesn't change any existing k6 behavior (see how the tests were not touched), but it adds hooks for distributed execution later on.
na--
force-pushed
the
local-execution-controller
branch
from
fd81209
to
19a30e2
Compare
mstoykov
approved these changes
Dec 13, 2023
oleiade
approved these changes
Jan 11, 2024
|
🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is another sliver of the newly refactored #2816, a follow-up to #3191.
It adds the concept of an
execution.Controller, a very lightweight API by which multiple k6 instances could synchronize the concurrent execution of different segments of the same test run. However, it doesn't actually add any distributed execution by itself, just alocalimplementation of it that doesn't do anything (because a single instance doesn't need to synchronize with itself... yet 😅)Why?
This is a backwards-compatible prerequisite for distributed execution.
As you can see, no tests have been changed beyond adding the extra parameter to
execution.NewScheduler(). So this doesn't change any existing k6 behavior. However, it makes merging the distributed execution much easier because it reduces the likelihood of conflicts. For example, I recently had to resolve conflicts between #2816 and #3112. Even ignoring the code conflicts, logical conflicts are also easier to foresee when this is merged into the codebase, and it makes distributed execution a smaller and easier to review PR.Checklist
I have added tests for my changes.(not needed)make ci-like-lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)