Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to snappy framing #3134

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to snappy framing #3134

wants to merge 1 commit into from

Conversation

olegbespalov
Copy link
Collaborator

What?

Switch from the snappy to the snappy framing.

Why?

Closes: #3122

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #3134 (c89d2fe) into master (1df72a0) will decrease coverage by 0.05%.
The diff coverage is 32.00%.

❗ Current head c89d2fe differs from pull request most recent head d7fb6d2. Consider uploading reports for the commit d7fb6d2 to get more accurate results

@@            Coverage Diff             @@
##           master    #3134      +/-   ##
==========================================
- Coverage   71.98%   71.94%   -0.05%     
==========================================
  Files         252      252              
  Lines       19405    19427      +22     
==========================================
+ Hits        13969    13977       +8     
- Misses       4542     4553      +11     
- Partials      894      897       +3     
Flag Coverage Δ
ubuntu 71.88% <32.00%> (-0.03%) ⬇️
windows 71.79% <32.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudapi/config.go 88.67% <0.00%> (-1.71%) ⬇️
output/cloud/expv2/metrics_client.go 46.15% <31.81%> (-13.23%) ⬇️
output/cloud/expv2/output.go 66.01% <100.00%> (ø)

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snappy-Framing support
2 participants