Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #2251 from grafana/fix/1443_remove_the_js_… #2335

Merged
merged 1 commit into from Jan 14, 2022

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Jan 14, 2022

This reverts commit 83dc49b, reversing
changes made to 57ec741.

This merged feature has been found to cause issues in unexpected
scenarios involving threshold parsing. Reverting until those are
addressed.

Reopens #2251 and #1443.
Refs #2330

…runtime_from_threshold_calcultations"

This reverts commit 83dc49b, reversing
changes made to 57ec741.

This merged feature has been found to cause issues in unexpected
scenarios involving threshold parsing. Reverting until those are
addressed.
@oleiade oleiade added the bug label Jan 14, 2022
@oleiade oleiade self-assigned this Jan 14, 2022
Copy link
Collaborator

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@na-- na-- added this to the v0.36.0 milestone Jan 14, 2022
@oleiade oleiade merged commit 13b2372 into master Jan 14, 2022
@oleiade oleiade deleted the revert/2251 branch January 14, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants