Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add InterruptedIterations metric #1769

Closed
wants to merge 10 commits into from
Closed

[WIP] Add InterruptedIterations metric #1769

wants to merge 10 commits into from

Commits on Dec 14, 2020

  1. Add InterruptedIterations metric

    Ivan Mirić committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    4448bbf View commit details
    Browse the repository at this point in the history

  2. Add hack to avoid emitting 0 value for metric

    Ivan Mirić committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e2b88ab View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Align MiniRunner state handling with js.Runner

    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    645261a View commit details
    Browse the repository at this point in the history

  2. Add metrics emission tests for InterruptedIterations

    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    355ee1c View commit details
    Browse the repository at this point in the history

  3. Treat errors from Throw() as plain goja values 

    This avoids outputting "GoError" as mentioned in
#877 (comment)
    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    82dae16 View commit details
    Browse the repository at this point in the history

  4. WIP Disable emitting InterruptedIterations on done context 

    This is definitely racy and causes hanging in tests, so it needs a
different approach.
    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ebd2d34 View commit details
    Browse the repository at this point in the history

  5. Avoid cloning tags on each iteration

    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    9b47ec8 View commit details
    Browse the repository at this point in the history

  6. Enable metric pushing when run context is done 

    This isn't racy in real world tests since the Samples channel isn't
closed until the global context is done.
    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    b0b06c9 View commit details
    Browse the repository at this point in the history

  7. Fix context usage in some tests, add metrics processing delay

    Ivan Mirić committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c12f449 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Refactor VU error handling 

    This was motivated by wanting to remove the goja dependency from the
lib/executor package, see #1769 (comment)

The idea is for runFn to always return a lib.Exception error that can
handle all JS errors and Go panics consistently. In practice I'm not
sure if this hack is worth it as it might mess up handling of some
errors...
    Ivan Mirić committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    d52efc4 View commit details
    Browse the repository at this point in the history