New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop some corejs #1714
Drop some corejs #1714
Conversation
This reduces the mem used for the main.js script from #1167 (comment) by 50% and the load start time from 33 seconds to 10 seconds for 5k VUs |
Things that I would've liked more:
|
The shim.min.js was generating by running ``` grunt "build:es7,es6.promise" "--blacklist=es7.math,es7.array.includes" "--library=off" "--path=custom" "uglify" ``` inside corejs checkedout to tag v2.5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! 🎉
Can we make that grunt
command part of the Makefile
? For reference, if nothing else.
I would still prefer if we can try at
As that IMO is much better ... unfortunately it turned out to be more involved than what I hoped for so I decided to leave it for later :D |
test262 results mstoykov/k6-test262#1 |
superseeded by #1732 |
The shim.min.js was generating by running
inside corejs checkedout to tag v2.5.1