Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ws.Set(Timeout/Interval) panicking on float values #1608

Merged
merged 2 commits into from
Aug 28, 2020

Commits on Aug 26, 2020

  1. Fix ws.Set(Timeout/Interval) panicking on float values

    The issue is connected to dop251/goja#190 in the
    sense that instead of the float to int conversation to result in either
    error or a clamped float value, it results in a 0 int value which panics
    the stdlib time package.
    
    Changing the parameter for the timeout/interval to float both makes it
    possible to take values such as 0.5, meaning half a ms, and also checks
    if the value is positive so we can be certain that it won't panic k6.
    If not this results in an exception in the script.
    mstoykov committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    6a5c5da View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Update js/modules/k6/ws/ws.go

    Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
    mstoykov and Ivan Mirić committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    04e25be View commit details
    Browse the repository at this point in the history