Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snappy-Framing support #3122

Open
Tracked by #3117
olegbespalov opened this issue Jun 14, 2023 · 1 comment · May be fixed by #3134
Open
Tracked by #3117

Snappy-Framing support #3122

olegbespalov opened this issue Jun 14, 2023 · 1 comment · May be fixed by #3134

Comments

@olegbespalov
Copy link
Collaborator

olegbespalov commented Jun 14, 2023

What?

Implement Snappy-Framing format, which is enabled by Content-encoding: x-snappy-framed

Why?

Our backend supports it.

@olegbespalov olegbespalov changed the title Revaluate the current periodic and abort signal architecture/interaction Snappy-Framing support Jun 14, 2023
@olegbespalov olegbespalov self-assigned this Jun 14, 2023
@olegbespalov olegbespalov reopened this Jun 14, 2023
@olegbespalov olegbespalov linked a pull request Jun 20, 2023 that will close this issue
@mstoykov
Copy link
Collaborator

I would like to point out that the idea here is actually to not continuously allocate new []byte instances multiple times per each push.

You can see my original comment here

As well as somewhat relevant one about usage of sync.Pool here.

Depending on how well this works we might want to reintroduce sync.Pool. Or even just recompressing/rencoding the body on each time we need to send it.

tl;dr: the point is not just to use the snappy-framing support, but to use it to optimize how we send the packet.

@olegbespalov olegbespalov removed their assignment Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants