Added Sum stat resolver

grafana · Nov 29, 2022 · 17415ca · 17415ca
1 parent 616e5e2
commit 17415ca
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/metrics/sample.go b/metrics/sample.go
@@ -145,6 +145,7 @@ func GetResolversForTrendColumns(trendColumns []string) (map[string]func(s *Tren
 		"med":   func(s *TrendSink) float64 { return s.P(0.5) },
 		"max":   func(s *TrendSink) float64 { return s.Max },
 		"count": func(s *TrendSink) float64 { return float64(s.Count) },
+		"sum":   func(s *TrendSink) float64 { return s.Sum },
 	}
 	dynamicResolver := func(percentile float64) func(s *TrendSink) float64 {
 		return func(s *TrendSink) float64 {

diff --git a/metrics/sample_test.go b/metrics/sample_test.go
@@ -42,7 +42,7 @@ func TestGetResolversForTrendColumnsValidation(t *testing.T) {
 		expErr bool
 	}{
 		{[]string{}, false},
-		{[]string{"avg", "min", "med", "max", "p(0)", "p(99)", "p(99.999)", "count"}, false},
+		{[]string{"avg", "min", "med", "max", "p(0)", "p(99)", "p(99.999)", "count", "sum"}, false},
 		{[]string{"avg", "p(err)"}, true},
 		{[]string{"nil", "p(err)"}, true},
 		{[]string{"p90"}, true},

diff --git a/metrics/value_type.go b/metrics/value_type.go
@@ -5,7 +5,7 @@ import "errors"
 // Possible values for ValueType.
 const (
 	Default = ValueType(iota) // Values are presented as-is
-	Time                      // Values are timestamps (nanoseconds)
+	Time                      // Values are timestamps (milliseconds)
 	Data                      // Values are data amounts (bytes)
 )