Skip to content

Commit

Permalink
golangci-lint: enable it for all issues not just new
Browse files Browse the repository at this point in the history
As now all lint issues are fixed we can enable without that option.

Unfortunately the option only looks at code at and around the places
that was changed and if any of it has new lint errors it will trigger.

That does mean that if you update golangci-lint - it won't showcase new
lint errors it triggers.

Also won't work if you add a bunch of code to the end an already
somewhat long function. As the lint error will be at the beginning of
the function.

Closes #769
  • Loading branch information
mstoykov committed Apr 25, 2024
1 parent eec9105 commit 1020b30
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .github/actions/lint/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,4 @@ runs:
uses: golangci/golangci-lint-action@349d20632dbaed38f0a492cc991152e3d351e854 # latest commit at the time that uses node20
with:
version: ${{ steps.getenv.outputs.GolangCIVersion }}
only-new-issues: true
args: "--config=${{ github.action_path }}/.golangci.yml"
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ check-linter-version:
## lint: Runs the linters.
lint: check-linter-version
echo "Running linters..."
golangci-lint run --out-format=tab --new-from-rev master ./...
golangci-lint run --out-format=tab ./...

## tests: Executes any unit tests.
tests:
Expand Down

0 comments on commit 1020b30

Please sign in to comment.