New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Stream class docs #1535
gRPC Stream class docs #1535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small edits, other than that everything looks good! Might need to run prettier again on the files to fix the tables if you accept them. 🙇
docs/sources/v0.49.x/javascript-api/k6-net-grpc/stream/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.50.x/javascript-api/k6-net-grpc/stream/_index.md
Outdated
Show resolved
Hide resolved
@heitortsergent thanks! 👍 I hope I've applied all the suggestions in a separate commit. Could you please have a final look and re-approve it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
What?
This change fixes the missed gRPC Stream class signature and improves its documentation.
Checklist
npm start
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.Related PR(s)/Issue(s)
Spotted during https://community.grafana.com/t/k6-server-grpc-streaming-with-accesstoken-metadata/117879