Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v0.50.x documentation #1533

Merged
merged 1 commit into from Mar 25, 2024
Merged

Publish v0.50.x documentation #1533

merged 1 commit into from Mar 25, 2024

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Mar 25, 2024

What?

This PR copies the latest state of the sources/next folder as sources/v0.50.x. It also addresses a bunch of eslint issues that kept me from committing the changes and somehow found their way to the upstream 🙇🏻

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

k6/#3577

@@ -40,5 +40,6 @@ module.exports = {
__ENV: 'readonly',
__ITER: 'readonly',
open: 'readonly',
window: 'readonly',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the error you get that this is fixing?

Copy link
Member Author

@oleiade oleiade Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It addresses stuff like the following: https://github.com/grafana/k6-docs/pull/1533/files#diff-8c065fb2955bda9e9152922061225c2e47321ad1fd0229e2953087a6ae35685bR143

This file is full of them. I looked into the docs, and couldn't find any mention of window related to the browser module; that would explain where it comes from at least. Eslint complains this is unimported, so my "carpet bombing" solution was to essentially tell it to ignore it, I'm open to any alternative 👍🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the PR is huge, GitHub struggles to open the link I pasted ☝🏻 on my side. Here's the current next folder version of the window usage I referred to:

window.performance.measure('total-action-time', 'page-visit', 'action-completed')

@oleiade oleiade merged commit 9ca274a into main Mar 25, 2024
5 checks passed
@oleiade oleiade deleted the release-v0.50.0 branch March 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants