Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabalize k6/experimental/timers #28

Merged
merged 3 commits into from Mar 18, 2024
Merged

Stabalize k6/experimental/timers #28

merged 3 commits into from Mar 18, 2024

Conversation

mstoykov
Copy link

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

Copy link

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor suggestion for code comments, but it mostly looks good! 👍🏻

types/k6/timers.d.ts Outdated Show resolved Hide resolved
types/k6/timers.d.ts Outdated Show resolved Hide resolved
types/k6/timers.d.ts Outdated Show resolved Hide resolved
mstoykov and others added 2 commits March 18, 2024 10:56
Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
@oleiade oleiade merged commit ade6745 into release-v0.50.0 Mar 18, 2024
3 checks passed
@oleiade oleiade deleted the timersUpdate branch March 18, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants