Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcrypto and options.cloud changes #27

Merged
merged 2 commits into from Mar 18, 2024
Merged

Conversation

olegbespalov
Copy link

@olegbespalov olegbespalov commented Mar 15, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@olegbespalov olegbespalov mentioned this pull request Mar 15, 2024
28 tasks
@olegbespalov olegbespalov changed the title Webcrypto and options.cloud chnages Webcrypto and options.cloud changes Mar 15, 2024

/**
* JSON Web Key Value.
* JWKs are not supported for now, since webcrypto doesn't support exporting key/pairs
Copy link

@joanlopez joanlopez Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully get this sentence 🤔 By reading it, I'd not expect the following to be possible:

crypto.subtle.exportKey("jwk", aesCryptoKey);

But, in theory, it is 👍🏻

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully get this sentence

It's an attempt to mention that we have yet to support multiply (JWKs) since there is no functionality in our webcrypto implementation to export/import key pairs.

@oleiade oleiade merged commit b217ee5 into release-v0.50.0 Mar 18, 2024
3 checks passed
@oleiade oleiade deleted the feat/webcrypto-options branch March 18, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants