Unified Storage: Adds metrics for database query counts #87781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owensmallwood
added
no-backport
|
Looks like it created some build issues in github.com/grafana/grafana/pkg/services/store/entity but otherwise LGTM 👍 |
inf0rmer
approved these changes
May 14, 2024
owensmallwood
changed the title
owensmallwood
deleted the
owensmallwood/unified-storage-add-metrics-for-database-query-counts
branch
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs Error messagehandling pull request closed event: deleting instance by slug: unexpected response status: status=502 responseBody= <title>502 Server Error</title>Error: Server ErrorThe server encountered a temporary error and could not complete your request.Please try again in 30 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow unified storage to get the
grafana_database_queries_duration_seconds_countmetric.