Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Wire recording rules feature toggle into limits struct #87778

Merged
merged 1 commit into from
May 14, 2024

Conversation

alexweav
Copy link
Contributor

What is this feature?
Tiny PR that whether recording rules are allowed or not as a limit, from Validation's perspective.
Makes limits now depend on both features toggles and config. Update tests accordingly.

This was split out of another PR in order to make the diff cleaner.

Which issue(s) does this PR fix?:

n/a

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@alexweav alexweav added area/alerting Grafana Alerting type/refactor no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 13, 2024
@alexweav alexweav added this to the 11.1.x milestone May 13, 2024
@alexweav alexweav requested a review from a team as a code owner May 13, 2024 21:29
@alexweav alexweav requested review from rwwiv, JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team May 13, 2024 21:29
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexweav alexweav merged commit e396580 into main May 14, 2024
25 checks passed
@alexweav alexweav deleted the alexweav/rr-toggle-as-limit branch May 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Grafana Alerting area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants