New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix link to values.yaml file #87014
Merged
chri2547
merged 1 commit into
grafana:main
from
NicholasPCole:nicholaspcole/fix-helm-values-link
May 2, 2024
Merged
Docs: Fix link to values.yaml file #87014
chri2547
merged 1 commit into
grafana:main
from
NicholasPCole:nicholaspcole/fix-helm-values-link
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers.
grafana-pr-automation
bot
added
type/docs
pr/external
This PR is from external contributor
labels
Apr 27, 2024
chri2547
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
chri2547
added
backport v10.3.x
Mark PR for automatic backport to v10.3.x
backport v10.4.x
backport v11.0.x
Mark PR for automatic backport to v11.0.x
labels
May 1, 2024
This PR must be merged before a backport PR will be created. |
2 similar comments
This PR must be merged before a backport PR will be created. |
This PR must be merged before a backport PR will be created. |
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
Fix link to values.yaml file Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers. (cherry picked from commit 64d5440)
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
Fix link to values.yaml file Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers. (cherry picked from commit 64d5440)
This was referenced May 2, 2024
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
Fix link to values.yaml file Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers. (cherry picked from commit 64d5440)
chri2547
pushed a commit
that referenced
this pull request
May 2, 2024
Docs: Fix link to values.yaml file (#87014) Fix link to values.yaml file Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers. (cherry picked from commit 64d5440) Co-authored-by: Nicholas P. Cole <nicholas@nicholaspcole.com>
chri2547
pushed a commit
that referenced
this pull request
May 2, 2024
Docs: Fix link to values.yaml file (#87014) Fix link to values.yaml file Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers. (cherry picked from commit 64d5440) Co-authored-by: Nicholas P. Cole <nicholas@nicholaspcole.com>
chri2547
pushed a commit
that referenced
this pull request
May 2, 2024
Docs: Fix link to values.yaml file (#87014) Fix link to values.yaml file Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers. (cherry picked from commit 64d5440) Co-authored-by: Nicholas P. Cole <nicholas@nicholaspcole.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport v10.3.x
Mark PR for automatic backport to v10.3.x
backport v10.4.x
backport v11.0.x
Mark PR for automatic backport to v11.0.x
no-changelog
Skip including change in changelog/release notes
pr/external
This PR is from external contributor
type/docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes a link to the
values.yaml
file on GitHub.Why do we need this feature?
Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers.
Who is this feature for?
Users reading the docs for installing Grafana on Helm charts.
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer:
n/a