Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix link to values.yaml file #87014

Merged

Conversation

NicholasPCole
Copy link
Contributor

@NicholasPCole NicholasPCole commented Apr 27, 2024

What is this feature?

This PR fixes a link to the values.yaml file on GitHub.

Why do we need this feature?

Linking to the "edit" URL fails if the reader doesn't have write access to the repo: they'll be prompted to fork the repo or to sign in to GitHub. Instead link to the "blob" URL which is accessible to all readers.

Who is this feature for?

Users reading the docs for installing Grafana on Helm charts.

Which issue(s) does this PR fix?:

n/a

Special notes for your reviewer:

n/a

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2024

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added type/docs pr/external This PR is from external contributor labels Apr 27, 2024
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@chri2547 chri2547 added backport v10.3.x Mark PR for automatic backport to v10.3.x backport v10.4.x backport v11.0.x Mark PR for automatic backport to v11.0.x labels May 1, 2024
@chri2547 chri2547 added this to the 11.0.x milestone May 1, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

2 similar comments
Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

This PR must be merged before a backport PR will be created.

@chri2547 chri2547 modified the milestones: 11.0.x, 10.0.x, 11.1.x May 2, 2024
@chri2547 chri2547 added the no-changelog Skip including change in changelog/release notes label May 2, 2024
@chri2547 chri2547 merged commit 64d5440 into grafana:main May 2, 2024
35 checks passed
grafana-delivery-bot bot pushed a commit that referenced this pull request May 2, 2024
Fix link to values.yaml file

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.

(cherry picked from commit 64d5440)
grafana-delivery-bot bot pushed a commit that referenced this pull request May 2, 2024
Fix link to values.yaml file

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.

(cherry picked from commit 64d5440)
grafana-delivery-bot bot pushed a commit that referenced this pull request May 2, 2024
Fix link to values.yaml file

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.

(cherry picked from commit 64d5440)
chri2547 pushed a commit that referenced this pull request May 2, 2024
Docs: Fix link to values.yaml file (#87014)

Fix link to values.yaml file

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.

(cherry picked from commit 64d5440)

Co-authored-by: Nicholas P. Cole <nicholas@nicholaspcole.com>
chri2547 pushed a commit that referenced this pull request May 2, 2024
Docs: Fix link to values.yaml file (#87014)

Fix link to values.yaml file

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.

(cherry picked from commit 64d5440)

Co-authored-by: Nicholas P. Cole <nicholas@nicholaspcole.com>
chri2547 pushed a commit that referenced this pull request May 2, 2024
Docs: Fix link to values.yaml file (#87014)

Fix link to values.yaml file

Linking to the "edit" URL fails if the reader doesn't have write access
to the repo: they'll be prompted to fork the repo or to sign in to
GitHub. Instead link to the "blob" URL which is accessible to all
readers.

(cherry picked from commit 64d5440)

Co-authored-by: Nicholas P. Cole <nicholas@nicholaspcole.com>
@NicholasPCole NicholasPCole deleted the nicholaspcole/fix-helm-values-link branch May 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v10.3.x Mark PR for automatic backport to v10.3.x backport v10.4.x backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes pr/external This PR is from external contributor type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants