Docs: Add thresholds shared content #87009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatwawana
added
type/docs
no-changelog
imatwawana
requested review from
a team,
leeoniya and
drew08t
and removed request for
Eve832 and
a team
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
nmarrs
changed the title
baldm0mma
approved these changes
Apr 26, 2024
nmarrs
approved these changes
Apr 26, 2024
| comments: | | ||
| There are two thresholds shared files, thresholds-options-1.md and thresholds-options-2.md, to cover the most common combinations of options. | ||
| Using two shared files ensures that content remains consistent across visualizations that share the same options and users don't have to figure out which options apply to a specific visualization when reading that content. | ||
| This file is used in the following visualizations: bar chart, candlestick, time series, trend |
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Added thresholds shared files * Added shared files to visualizations and updated shared files * Removed future tense * Fixed prettier (cherry picked from commit 406fe8c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds shared files for the thresholds options for visualizations. Two files have been added to cover the two most common sets of options. Using two shared files ensures two things:
This PR: