Canvas: Fix connection hyperbolic bug #87002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew08t
added
type/bug
area/panel/canvas
drew08t
requested review from
Develer and
nmarrs
and removed request for
a team
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
Develer
approved these changes
Apr 26, 2024
nmarrs
approved these changes
Apr 26, 2024
codeincarnate
approved these changes
Apr 26, 2024
baldm0mma
approved these changes
Apr 26, 2024
Base automatically changed from
drew08t/canvas-connection-original-check
to
main
April 29, 2024 15:23
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Canvas: Connection original persistence check * Canvas: Fix connection hyperbolic bug (cherry picked from commit 49fbe97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyperbolic behavior was occurring for the first segment with curves under certain conditions. This was because the check for next segment length was based on the wrong (old) coordinate system. This simply switches the logic check to the new coordinate system.
Before:
After:
Closes #86933