New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Upgrade otel dependencies #86994
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
091273b
Chore: Upgrade otel dependencies
marefr 1fbd53e
sdk changes
marefr 2469522
ignore deprecated go.opentelemetry.io/otel/exporters/jaeger for now
marefr 90ec1fb
Merge remote-tracking branch 'origin' into chore_upgr_otel
marefr c0edf69
Merge remote-tracking branch 'origin' into chore_upgr_otel
marefr 0a4accd
use latest commit from sdk branch
marefr a1fd150
sdk v0.228.0
marefr 8abf58c
Merge remote-tracking branch 'origin' into chore_upgr_otel
marefr File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be in go.work so that it is used in all sub-modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. When new release of SDK is tagged the replace is removed and go.mod files updated in each module. I guess you mean for the purpose of testing these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice with a similar command
go mod edit -replace github.com/grafana/grafana-plugin-sdk-go=github.com/grafana/grafana-plugin-sdk-go@5fe9f7b9dfd42396cc596c72084afbb3ffc39f28
forgo work
. Guess that doesn't exist?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did update go.work instead. Was a bit weird since I first had to add it to go.mod with a go mod edit as above and then
go mod tidy
and then move the replace line into go.work.