Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs / alerting / fundamentals / templates #86983

Merged
merged 13 commits into from Apr 30, 2024
Merged

docs / alerting / fundamentals / templates #86983

merged 13 commits into from Apr 30, 2024

Conversation

tonypowa
Copy link
Contributor

@tonypowa tonypowa commented Apr 26, 2024

This PR :

  • moved the "template" page into a new folder named "templates"
  • renamed the above page so it becomes the index page of that folder
  • created a sub-page "label-annotations" which basically contains the content from the existing labels and annotations page plus some elaboration on the templating part

TODO:

  • test with make docs
  • check if tree structure and file names are correct
  • check if front matter is correct

@tonypowa tonypowa added type/docs no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 26, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 26, 2024
@tonypowa
Copy link
Contributor Author

will add the notif template part to this PR . ill let you know @brendamuir

@tonypowa
Copy link
Contributor Author

hi @brendamuir I have applied the changes we discussed the other day
i will test how it looks locallyy and let you know

tonypowa and others added 6 commits April 30, 2024 11:50
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
@tonypowa tonypowa merged commit 9203f84 into main Apr 30, 2024
11 checks passed
@tonypowa tonypowa deleted the tonypowa/labels branch April 30, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants