Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Server: Make message size limits configurable. #86982

Merged
merged 3 commits into from Apr 30, 2024

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented Apr 26, 2024

What is this feature?
Adds two new configuration options for the gRPC server to configure message size limits:

  • max_recv_msg_size
  • max_send_msg_size

The options are just passed through to the gRPC server as options.

Why do we need this feature?
These options are important for limiting memory use by gRPC, but the default for receive is often low. Being able to change these limits is crucial.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 26, 2024
@stevesg stevesg force-pushed the stevesg/make-grpc-server-msg-limits-configurable branch 3 times, most recently from 0dc48ab to e66551c Compare April 26, 2024 12:37
@stevesg stevesg force-pushed the stevesg/make-grpc-server-msg-limits-configurable branch from e66551c to 746090c Compare April 30, 2024 07:15
@stevesg stevesg marked this pull request as ready for review April 30, 2024 07:16
@stevesg stevesg requested review from torkelo and a team as code owners April 30, 2024 07:16
@stevesg stevesg added the no-changelog Skip including change in changelog/release notes label Apr 30, 2024
Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

conf/defaults.ini Outdated Show resolved Hide resolved
conf/defaults.ini Outdated Show resolved Hide resolved
Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com>
@stevesg stevesg merged commit 5c89b8f into main Apr 30, 2024
12 checks passed
@stevesg stevesg deleted the stevesg/make-grpc-server-msg-limits-configurable branch April 30, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants