Auth: Add OrgRoleMapper service #86973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamab
reviewed
Apr 26, 2024
mgyongyosi
added
the
no-changelog
mgyongyosi
force-pushed
the
mgyongyosi/add-org-role-mapper
branch
from
4d497cc
to
dc77536
Compare
mgyongyosi
force-pushed
the
mgyongyosi/add-org-role-mapper
branch
from
dc77536
to
242d74c
Compare
mgyongyosi
force-pushed
the
mgyongyosi/add-org-role-mapper
branch
from
242d74c
to
2423f46
Compare
kalleep
reviewed
Apr 26, 2024
kalleep
previously approved these changes
Apr 30, 2024
mgyongyosi
dismissed
kalleep’s stale review
Found other issues, removing the approval to make sure nobody merge this accidentally
mgyongyosi
force-pushed
the
mgyongyosi/add-org-role-mapper
branch
from
0438541
to
03498fe
Compare
mgyongyosi
force-pushed
the
mgyongyosi/add-org-role-mapper
branch
from
66f50fb
to
de1d94b
Compare
gamab
approved these changes
May 3, 2024
| expected: map[int64]org.RoleType{2: org.RoleEditor}, | ||
| }, | ||
| { | ||
| name: "should return nil if the org mapping contains at least one invalid setting and directly mapped role is empty and strict role mapping is enabled", |
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
…ettings Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds an OrgRoleMapper that will be used by the OAuth connectors to implement OrgRole mapping. This mapper meets all of the OrgRole mapping requirements that is implemented by SAML.
Why do we need this feature?
Prerequisite for implementing OrgRole mapping for OAuth providers. It's extracted from #77683.
Who is this feature for?
#77683
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: