Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore and Correlations: Replace deprecated layout components #86967

Merged
merged 1 commit into from Apr 29, 2024
Merged

Explore and Correlations: Replace deprecated layout components #86967

merged 1 commit into from Apr 29, 2024

Conversation

harisrozajac
Copy link
Contributor

What is this feature?

Replaces deprecated HorizontalGroup and VerticalGroup components with Stack. I've tested all affected components, and everything looks good:

CorrelationFormNavigation
Screenshot 2024-04-26 at 11 05 55 AM

CorrelationEditorModeBar
Screenshot 2024-04-26 at 11 05 07 AM

ConfirmNavigationModal
Screenshot 2024-04-26 at 11 04 46 AM

Which issue(s) does this PR fix?:

Fixes: #86839

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.

@harisrozajac harisrozajac requested review from grafanabot and a team as code owners April 26, 2024 09:09
@harisrozajac harisrozajac self-assigned this Apr 26, 2024
@harisrozajac harisrozajac added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes area/explore labels Apr 26, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 26, 2024
@harisrozajac harisrozajac changed the title Replace deprecated layout components Explore and Correlations: Replace deprecated layout components Apr 26, 2024
ifrost
ifrost approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ifrost ifrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

There's a weird gap at the top of the correlations editor bar but it's not related to these changes and it's happening in main as well so it can be tackled separately

Screenshot 2024-04-29 at 14 41 55

@gelicia gelicia enabled auto-merge (squash) April 29, 2024 12:49
@gelicia gelicia merged commit b52e349 into main Apr 29, 2024
30 checks passed
@gelicia gelicia deleted the haris/replace-deprecated-layout-components branch April 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifrost ifrost ifrost approved these changes

@gelicia gelicia gelicia approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees

@harisrozajac harisrozajac

Labels
area/explore area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup
3 participants
@harisrozajac @ifrost @gelicia