Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard scenes: Fix min interval not saving #86962

Merged
merged 3 commits into from Apr 29, 2024

Conversation

oscarkilhed
Copy link
Contributor

@oscarkilhed oscarkilhed commented Apr 26, 2024

What is this feature?
Fixes a bug where min interval is not saved or used in scenes.

Fixes #86943

@oscarkilhed oscarkilhed added type/bug no-changelog Skip including change in changelog/release notes area/scenes backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 26, 2024
@oscarkilhed oscarkilhed requested a review from a team as a code owner April 26, 2024 07:46
@oscarkilhed oscarkilhed requested review from ivanortegaalba and bfmatei and removed request for a team April 26, 2024 07:46
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 26, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 LGTM

@oscarkilhed oscarkilhed merged commit fdc1023 into main Apr 29, 2024
14 checks passed
@oscarkilhed oscarkilhed deleted the oscark/fix-min-interval-not-saving branch April 29, 2024 07:41
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 29, 2024
* Fix min interval not saving

* Add tests

* Fix test

(cherry picked from commit fdc1023)
oscarkilhed added a commit that referenced this pull request Apr 29, 2024
Dashboard scenes: Fix min interval not saving (#86962)

* Fix min interval not saving

* Add tests

* Fix test

(cherry picked from commit fdc1023)

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend area/scenes backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

DashboardScene: Migration - min-interval settings is not persisted between saves anymore.
2 participants