Graphite: Fix splitting expressions in tag_value with template variables #86958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
correct spilitting expressions in tag_value with template variables, grafana produce incorrect query for resolve variable with tag_values when depend on multi-value variable with several selected items
Why do we need this feature?
So the graphite queries work as expected
How to reproduce it:
Add 2 variables
route="test1,test2" (Custom type)
gateway="tag_values(route, route = ${route})" (Query on Graphite Datasource with refresh on Time Range Change)
On dashboard for variable route try to select test1 and test2
For resolve variable route incorrect query was formed
/api/datasources/proxy/2/tags/autoComplete/values?expr=route = {test1&expr=test2}&tag=route&limit=10000&from=1619180806&until=1619181708
Correct query parameter for expr=route is
expr=route={test,test2}
Who is this feature for?
Developers
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: