Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.0.x] JWT: Find login and email claims with JMESPATH #86357

Merged
merged 1 commit into from Apr 16, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport e4250a7 from #85305


What is this feature?

This feature will resolve login/username and email claims using JMESPath. This will allow us to use rootClaim.subClaim.listOfEmails[0].

Why do we need this feature?

This has been requested in the past. However, this won't solve the issue for Google's JWT subclaim gcip since that needs to be parsed again.

#75856

Who is this feature for?

IAM

Which issue(s) does this PR fix?:

Fixes #69451

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

* add function to static function to static service

* find email and login claims with jmespath

* rename configuration files

* Replace JWTClaims struct for map

* check for subclaims error

(cherry picked from commit e4250a7)
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 16, 2024
@grafana-delivery-bot grafana-delivery-bot bot requested review from mildwonkey, undef1nd and suntala and removed request for a team April 16, 2024 14:50
@grafana-delivery-bot grafana-delivery-bot bot added area/backend backport A backport PR no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs labels Apr 16, 2024
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 merged commit 6f6667d into v11.0.x Apr 16, 2024
23 checks passed
@ashharrison90 ashharrison90 deleted the backport-85305-to-v11.0.x branch April 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend backport A backport PR no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants