DataLinks: Fixes datalinks with onClick and variables in url not being interpolated

[gng0]

Added the replaceVariables method to be used on the link url when an onClick handler is provided.
Fixed a unit test and added another test for this fix. More details in the issue

Fixes #86242

[CLAassistant]

All committers have signed the CLA.

[torkelo]

Thanks for contributing and fixing this!

[axelavargas]

@gng0 thank you for contributing to Grafana 🙌🏾 . I see some failures in our CI, can you update your branch with the latest main?

🙏🏾

[gng0]

Done! @axelavargas

[gng0]

Hi @torkelo, just wanted to follow up on the continuous-integration/drone/pr build which is pending. The details links me to a page mentioning - "Build is blocked, please, contact repo admin in order to proceed"

[axelavargas]

Hey @gng0, I checked the code and noticed some missing href processing in the approach :), I left a comment.

I will be keeping an eye on this PR, as soon as the change is implemented, I will approve :)

[axelavargas]

Hey @gng0 👋🏾, thanks for contributing to this change 🙌🏾 . Can you refactor this part to contain the same href processing we do in the else condition?

.....
  if (href) {
    href = locationUtil.assureBaseUrl(href.replace(/\n/g, ''));
    href = replaceVariables(href, dataLinkScopedVars, VariableFormatID.UriEncode);
    href = locationUtil.processUrl(href);

[gng0]

Thanks for catching that @axelavargas
I've just made the change!

[axelavargas]

🥳

[axelavargas]

🤔 the CI is failing again, prettier issues:

Output of the CI

yarn run prettier:check
[warn] packages/grafana-data/src/field/fieldOverrides.ts
[warn] Code style issues found in the above file. Run Prettier to fix.

[ivanortegaalba]

Hi @gng0,

The prettier formatting probably doesn't happen because you don't have the pre-commit hooks configured :)

https://github.com/grafana/grafana/blob/main/contribute/developer-guide.md#configure-precommit-hooks

Can I ask you to give a check, run prettier on the pushed code so we can merge? I can't push to your fork to fix it 😄

Thank you!

[gng0]

@axelavargas @ivanortegaalba just bumping this 😄