[v11.0.x] samlsettings: api integration #86109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* add strategy and tests * use settings provider service and remove multiple providers strategy * Move SAML strategy to ssosettings service * Update codeowners file * reload from settings provider * add saml as configurable provider * Add new SAML strategy * rename old saml settings interface * update saml string references * use OSS license * validate saml provider depends on license for List * add tests for list rendering including saml * change the licensing validation to service init * replace service struct for provider (cherry picked from commit fc205db)
grafana-delivery-bot
bot
requested review from
papagian,
diegommm and
undef1nd
and removed request for
a team
grafana-delivery-bot
bot
added
area/auth/saml
area/backend
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fc205db from #84300
What is this feature?
This PR registers the sso settings saml strategy; this way we can update and retrieve saml sso settings from the sso endpoints. This PR also renames the functions of the old saml strategy interface, since they're not compatible with the new sso settings interface.
Why do we need this feature?
This PR allows to interact and save the saml settings via the sso settings api
Who is this feature for?
IAM
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/identity-access-team/issues/594
Special notes for your reviewer:
Please check that: