Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO: add the missing fields to the okta provider #85152

Merged
merged 2 commits into from Mar 26, 2024

Conversation

dmihai
Copy link
Contributor

@dmihai dmihai commented Mar 26, 2024

What is this feature?

Adding the missing allowSignUp and autoLogin fields to the okta provider in the UI.

Why do we need this feature?

The okta provider was missing some fields in the SSO settings UI.

Who is this feature for?

everybody

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@dmihai dmihai requested a review from a team March 26, 2024 11:02
@dmihai dmihai requested a review from a team as a code owner March 26, 2024 11:02
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Mar 26, 2024
@dmihai dmihai added the no-changelog Skip including change in changelog/release notes label Mar 26, 2024
@dmihai dmihai changed the title SSO: add the missing allowSignUp field to okta provider SSO: add the missing fields to the okta provider Mar 26, 2024
@dmihai dmihai added the backport v11.0.x Mark PR for automatic backport to v11.0.x label Mar 26, 2024
Copy link
Contributor

Hello @dmihai!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link
Contributor

This PR must be merged before a backport PR will be created.

@dmihai dmihai merged commit 6ddced7 into main Mar 26, 2024
29 checks passed
@dmihai dmihai deleted the dmihai/sso-okta-add-allow-sign-up branch March 26, 2024 12:45
grafana-delivery-bot bot pushed a commit that referenced this pull request Mar 26, 2024
* add the missing allowSignUp field to okta provider

* add autoLogin to okta

(cherry picked from commit 6ddced7)
dmihai added a commit that referenced this pull request Mar 26, 2024
SSO: add the missing fields to the okta provider (#85152)

* add the missing allowSignUp field to okta provider

* add autoLogin to okta

(cherry picked from commit 6ddced7)

Co-authored-by: Mihai Doarna <mihai.doarna@grafana.com>
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants