Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDFowrarding: ignore logging context canceled errors #85141

Merged
merged 1 commit into from Mar 26, 2024
Merged

IDFowrarding: ignore logging context canceled errors #85141

merged 1 commit into from Mar 26, 2024

Conversation

kalleep
Copy link
Contributor

@kalleep kalleep commented Mar 26, 2024

What is this feature?
Reduce some error logging noise. We can skip logging context cancellations

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kalleep kalleep added the no-changelog Skip including change in changelog/release notes label Mar 26, 2024
@kalleep kalleep added this to the 11.1.x milestone Mar 26, 2024
@kalleep kalleep requested a review from a team as a code owner March 26, 2024 09:21
@kalleep kalleep merged commit 2f5e302 into main Mar 26, 2024
24 checks passed
@kalleep kalleep deleted the idforwarding/logging branch March 26, 2024 10:36
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 15, 2024
@ashharrison90 ashharrison90 added product-approved Pull requests that are approved by product/managers and are allowed to be backported backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 15, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
@kalleep @grafana-delivery-bot
IDFowrarding: ignore logging context canceled errors (#85141)
670dc89 
(cherry picked from commit 2f5e302)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Apr 15, 2024
Merged
3 tasks
ashharrison90 pushed a commit that referenced this pull request Apr 15, 2024
@grafana-delivery-bot @kalleep
[v11.0.x] IDFowrarding: ignore logging context canceled errors (#86187)
232798e 
IDFowrarding: ignore logging context canceled errors (#85141)

(cherry picked from commit 2f5e302)

Co-authored-by: Karl Persson <kalle.persson@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyongyosi mgyongyosi mgyongyosi approved these changes

Assignees
No one assigned
Labels
area/backend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalleep @mgyongyosi @ashharrison90