OAuth: Make sub claim required for generic oauth behind feature toggle #85065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyongyosi
approved these changes
Mar 25, 2024
kalleep
added a commit
that referenced
this pull request
Mar 25, 2024
#85065) * Add feature toggle for sub claims requirement * OAuth: require valid auth id * Fix feature toggle description
ashharrison90
added
product-approved
3 tasks
ashharrison90
pushed a commit
that referenced
this pull request
Apr 15, 2024
…ture toggle (#86118) OAuth: Make sub claim required for generic oauth behind feature toggle (#85065) * Add feature toggle for sub claims requirement * OAuth: require valid auth id * Fix feature toggle description (cherry picked from commit 2f3a01f) Co-authored-by: Karl Persson <kalle.persson@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Replacement for #84745.
As a first step we decided to require sub claim behind a feature toggle so we have a way to opt and give customers time to fix their oauth integrations.
I also decided to perform this check in oauth client instead of the generic oauth connector so we would catch other clients where this could happen as well.
Part of https://github.com/grafana/identity-access-team/issues/603
Special notes for your reviewer:
Please check that: