Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SigningKeys: Add added_at when creating new signing key #85060

Merged
merged 1 commit into from Mar 25, 2024
Merged

SigningKeys: Add added_at when creating new signing key #85060

merged 1 commit into from Mar 25, 2024

Conversation

kalleep
Copy link
Contributor

@kalleep kalleep commented Mar 25, 2024

What is this feature?
Add missing field when creating new signing key. Without the field this operation always fails with mysql as database

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kalleep kalleep added this to the 11.0.x milestone Mar 25, 2024
@kalleep kalleep requested a review from a team as a code owner March 25, 2024 08:36
@kalleep kalleep added the no-changelog Skip including change in changelog/release notes label Mar 25, 2024
@kalleep kalleep merged commit c33bc81 into main Mar 25, 2024
23 checks passed
@kalleep kalleep deleted the signingkeys/added-at branch March 25, 2024 08:58
@ashharrison90 ashharrison90 modified the milestones: 11.0.x, 11.1.x Mar 25, 2024
ashharrison90 pushed a commit that referenced this pull request Mar 26, 2024
@kalleep @ashharrison90
SigningKeys: Add added_at when creating new signing key (#85060)
b5f8c34
ashharrison90 pushed a commit that referenced this pull request Mar 26, 2024
@kalleep @ashharrison90
SigningKeys: Add added_at when creating new signing key (#85060)
48fd6f0
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.x Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyongyosi mgyongyosi mgyongyosi approved these changes

Assignees
No one assigned
Labels
area/backend no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalleep @mgyongyosi @ashharrison90 @fabrizio-grafana