Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust HD validation default value #83818

Merged
merged 1 commit into from Mar 4, 2024
Merged

Adjust HD validation default value #83818

merged 1 commit into from Mar 4, 2024

Conversation

linoman
Copy link
Contributor

@linoman linoman commented Mar 4, 2024

What is this feature?

Adjusts the default value for HD validation value for SSO Reload function.

Why do we need this feature?

The HD validation value needs to match when creating the Google Provider as for the Reload of the provider.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@linoman linoman added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 4, 2024
@linoman linoman added this to the 11.0.x milestone Mar 4, 2024
@linoman linoman self-assigned this Mar 4, 2024
@linoman linoman requested a review from a team as a code owner March 4, 2024 11:07
IevaVasiljeva
IevaVasiljeva reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@IevaVasiljeva IevaVasiljeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change?

@linoman linoman merged commit 67c062a into main Mar 4, 2024
23 checks passed
@linoman linoman deleted the linoman/google_oauth_default_hd_validation branch March 4, 2024 11:45
@linoman
Copy link
Contributor Author

linoman commented Mar 4, 2024

@IevaVasiljeva yes it is! You can read more about it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IevaVasiljeva IevaVasiljeva IevaVasiljeva left review comments

@mgyongyosi mgyongyosi mgyongyosi approved these changes

Assignees

@linoman linoman

Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@linoman @mgyongyosi @IevaVasiljeva @fabrizio-grafana