Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the certgenerator dskit service from apiserver #71166

Merged
merged 4 commits into from
Jul 8, 2023
Merged

use the certgenerator dskit service from apiserver #71166

merged 4 commits into from
Jul 8, 2023

Conversation

charandas
Copy link
Contributor

Uses the certgenerator service from apiserver package instead.

Depends on: https://github.com/grafana/grafana-apiserver/pull/31

@charandas charandas requested a review from toddtreece July 7, 2023 03:32
@charandas charandas self-assigned this Jul 7, 2023
charandas
charandas commented Jul 7, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@charandas charandas marked this pull request as ready for review July 7, 2023 23:50
@charandas charandas requested review from a team as code owners July 7, 2023 23:50
@charandas charandas requested review from sakjur, papagian and yangkb09 and removed request for a team July 7, 2023 23:50
ryantxu
ryantxu approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- feel free to merge things into feature branches like this. it seems the order of operatinos on merge/rebase strategies is the biggest challenge

@charandas charandas force-pushed the charandas/certgenerator-import-from-apiserver-pkg branch from ff908e4 to 4aa4669 Compare July 8, 2023 00:35
@charandas charandas force-pushed the charandas/certgenerator-import-from-apiserver-pkg branch from 4aa4669 to cb96bd7 Compare July 8, 2023 00:35
@charandas charandas merged commit f9fdcef into k8s-grafana-apiserver Jul 8, 2023
3 of 4 checks passed
@charandas charandas deleted the charandas/certgenerator-import-from-apiserver-pkg branch July 8, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantxu ryantxu ryantxu approved these changes

@toddtreece toddtreece Awaiting requested review from toddtreece

@sakjur sakjur Awaiting requested review from sakjur sakjur is a code owner automatically assigned from grafana/backend-platform

@papagian papagian Awaiting requested review from papagian papagian is a code owner automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 is a code owner automatically assigned from grafana/backend-platform

Assignees

@charandas charandas

Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charandas @ryantxu @grafanabot