Refactor admission handlers #70728
Closed
Refactor admission handlers #70728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* metrics schematize * metrics now use schemas * logs schema * remove unused code * fix tests
…nt value using uid. (#69259) * feat: template data source option current by uid * fix: e2e with explicit uid for "slow-prometheus" * revert: unrelated change * revert: unreverted the actually related change * chore: e2e support for testing ${variable:text} * fix: use `:raw` instead of `:value` in e2e dashboard
* Update dependency @grafana/faro-core to v1.1.0 * dedupe * update faro-web-sdk as well --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
drop margin-bottom
* Loki: Don't split queries if they use variables * Update public/app/plugins/datasource/loki/querySplitting.ts Co-authored-by: Matias Chomicki <matyax@gmail.com> --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Changelog: Updated changelog for 10.0.0-preview * Prettier changelog --------- Co-authored-by: Horst Gutmann <horst.gutmann@grafana.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
add tracking to predefined queries
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* [feat] Add scroll handlers to the Select component * [refactor] Update Select component - Update how `captureMenuScroll` boolean is set - Update props * [fix] revert unexpected changes
…ng/testing/publishing (#69911) * Created images.star * Fix typo * Add cronjobs for build-images
…rafana is served under a subpath (#69845) don't strip base from url since we're not using locationSrv.push anymore
* general edits * style edits - contractions * Update docs/sources/fundamentals/dashboards-overview/index.md Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update docs/sources/fundamentals/dashboards-overview/index.md Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Apply suggestions from code review * fixed linting error --------- Co-authored-by: David Allen <david.allen@grafana.com> Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Remove classNames from SubMenu
* add analytics for folder creation * add interaction tracking for move/delete * add tracking for item clicked in the new browse view * review comments * emit counts instead
* stay in the modal whilst actions complete * don't return anything here to fix types * ensure we're always resetting button state
* adds legacy topics * moves legacy and adds deprecation note * Merge branch 'alerting-docs-support-escalations' of https://github.com/grafana/grafana into alerting-docs-support-escalations * adds description * fixes relrefs * removes relrefs * removes relrefs * fixes links * Adds description frontmatter * fixing typo * adds frontmatter * fix spelling error
sdboyer
force-pushed
the
sdboyer/k8s-thema-validation
branch
from
4f66bf7
to
8e3ccac
Compare
|
This now works - dashboards pass kindsys-provided validation (using the new code in grafana/kindsys#22). With all the history messiness here i'll have to reroll this PR, and #69795, which i'll do tomorrow. There's a number of hacks here, including several to work around divergences between grafana/grafana and kindsys/app-sdk, but nothing we shouldn't be able to resolve pretty quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some modifications to #69795 to make that (AWESOME) PR use thema, and the existing core kinds codegen, in more of the expected way.
i started writing this as comments on #69795, but it ended up making a lot more sense to do it as a separate PR.
Please note, i haven't tested this, as i'm not sure what the usual testing procedures are for things on the poc branch.