WIP/GraphNG: support soft min max axis #30238
Conversation
|
i can land the remainder by the end of this week. should the JSON store the full config (rather than a unary value), so we have more flexibility to expose more subtle behavior in the future? |
|
another option supports both hard limits (clamping) and soft limits by using the Min/Max from "Standard options" for hard, and adds The soft limits will be inside the hard limits. The scale/axis range will start at the soft limits and expand to the hard limits when the data exceeds the softs, and will clip afterwards.
|
I am not sure that is a good idea, then we have to support that more complex model forever. The simpler the persisted model, the easier for us to change this & improve defaults. |
|
I like this |
|
@torkelo please read the recent comments onwards from #979 (comment) i think they're valid concerns, and the there's quite a lot of added flexibility gained from having 2 numeric fields instead of a toggle that neuters/repurposes clamping ability. i'm not sure of another way to accommodate spike-chopping in a softMin/max scenario if you cannot set hard limits as well. |
|
@leeoniya yea, maybe your right that separate soft min & max options would allow hard limits. Wish we could hide some of these advanced options so they are not always expanded/visible (to not overwhelm new users) |
@torkelo I was thinking along the same lines about this. I assume when we talk about the advanced options we consider the soft min/max numeric fields. I find the pattern we use for the axis scales something that could fit this use case as well when the numeric inputs are only shown when the soft mode is selected:
|
|
@dprokop but that would still require an always present soft mode option, and what would soft mode mean if you have not specified any values in the inputs? feels better to have soft min & soft max inputs but hide them & axis width, (and other future advanced options) in an advanced section or something :) |
* Add sigv4 overview and links to AWS docs * minor wording tweak * Update prometheus.md * move supported version in Prometheus-AMP docs Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * move supported version Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * move version support note Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
…ed to panels are off causing data points to be cut off (outside) (#30227) * runRequest: Fixes issue with request time range and time range returned to panels are off causing data points to be cut off (outside) * Updated test
…30146) Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* QueryMetricsV2: Stream response Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * API: Use jsoniter instead of standard JSON package Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* get meta data from dataframe meta * gmdMeta is not used anymore * wip: move deep link creation to backend * Refactor backend. Remove not used front end code * Unit test deep links. Remove not used frontend tests * remove reference to gmdmeta * fix goimports error * fixed after pr feedback * more changes according to pr feedback * fix lint issue * fix bad math expression check and fix bad test * Decrease nesting * put link on first data field only
- also add Get by UID+OrgID to datasource cache - Refactor backend commands for Delete and Get to be unified
Example `ec2_instance_attribute(default, InstanceId, { 'tag:Environment': ['production'] });` will cause `SyntaxError: Unexpected token ' in JSON at position 2`
* Update prometheus.md * Update docs/sources/datasources/prometheus.md Co-authored-by: Dan Cech <dcech@grafana.com> * Update prometheus.md Co-authored-by: Dan Cech <dcech@grafana.com>
|
superseded by #30326. |
Fixes #979
Status: this is currently just the settings scaffolding and does not implement the actual scaling
This adds an axis mode option:
TODO: