New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fix 1032: Allow custom mapping of template variable value -> display text #19972
Conversation
Please provide a relevant title and description of the change in this pull request. |
One comment for discussion (I like your pragmatic way): I really like to see some progress on this! [EDIT] Bonus question: Is it then possible to refer to both |
Thanks for your comment. Bonus answer: no, |
@torkelo @marcusolsson Any idea if that is something that can be merged as a starting point such feature would be really helpful to give more flexibility to the custom values without having to build a dummy datasource? |
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
I would like to ping this for review - it's a pretty nice feature that was already demanded in several requests. The approach of @marcoklaassen is pragmatic and a good point to start from. |
…nto bugfix/fix-1032
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
I really want this feature as many others. Could you please @marcusolsson check again? Or where it got stucked? |
Thanks for contributing! I do not think this addresses #1032, this adds value & text support to the custom variable, #1032 is about dynamic query based id -> text lookup for query variable options. We can't realy merge this, we are rewriting the template variable system to redux & react. #22434 Dont think json text in the input is the right answer here. Either a UI or support for CSV table (with text & vale columns) would be better. |
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Fixes #1032
use a json array to define variable lists with mapping of value and display text.
if you don't need a mapping, you can use the feature as before (comma separated list).
there is also an additional info-box containing a description how to build the json array.