Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(devenv): correct the context issue #17291

Merged
merged 1 commit into from May 27, 2019
Merged

Build(devenv): correct the context issue #17291

merged 1 commit into from May 27, 2019

Conversation

markelog
Copy link
Contributor

With the previous configuration docker-compose build was always failing.
This moves the dockerfiles in the parent dir and changes paths as a result.

Ref moby/moby#2745

With the previous configuration `docker-compose build` was always failing.
This moves the dockerfiles in the parent dir and changes paths as a result.

Ref moby/moby#2745
@markelog markelog requested a review from xlson May 27, 2019 08:00
Copy link
Contributor

@xlson xlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markelog markelog merged commit 2146f83 into master May 27, 2019
@markelog markelog deleted the multiple-ldap branch May 27, 2019 11:22
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants