Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flot plugin Candlestick with dependent library #10955

Closed
wants to merge 2 commits into from

Conversation

ilgizar
Copy link
Contributor

@ilgizar ilgizar commented Feb 17, 2018

To fix #516 need add the necessary plugin. Some examples of the work of the new panel plugin:
01
02
03
In this PR the panel plugin is not present, it while in development. It will be a separately installed plugin. But for his work, these changes are necessary.

@codecov-io
Copy link

codecov-io commented Feb 18, 2018

Codecov Report

Merging #10955 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10955   +/-   ##
=======================================
  Coverage   51.55%   51.55%           
=======================================
  Files         343      343           
  Lines       24244    24244           
  Branches     1414     1414           
=======================================
  Hits        12498    12498           
  Misses      11046    11046           
  Partials      700      700

@JamesGalt
Copy link

JamesGalt commented Feb 19, 2018

Hi,
I really would like to have candlesticks.
Will you make your plugin draw also classic graph (like the graph plugin) so we can draw BBands or EMA over the candlesticks?
Would be amazing
Thanks

@ilgizar
Copy link
Contributor Author

ilgizar commented Feb 19, 2018

@JamesGalt The implementation of analytical charts is complicated by the principle of obtaining data. For the construction of indicators, data for previous periods are needed, as long as there is no such possibility.

@JamesGalt
Copy link

JamesGalt commented Feb 19, 2018

@ilgizar I'm not talking about adding analytical charts directly, as I can compute them, just adding the possibility to draw line graphs so I can display them.
Perhaps by making the first metric returning OHLC+Volume used for candles and others displayed as lines.
A mix between your screenshot and the one below would be crazy ;)
screenshot
Thanks

@ilgizar
Copy link
Contributor Author

ilgizar commented Feb 19, 2018

@JamesGalt Draw metrics from external sources - not a problem.

@JamesGalt
Copy link

Nice,
Will be amazing!
Thanks!

@ilgizar
Copy link
Contributor Author

ilgizar commented Feb 19, 2018

@JamesGalt like this?
04

@JamesGalt
Copy link

@ilgizar Perfect!
You're the man, waiting for this feature for almost a year now!
If you need a beta tester I'm in!
Should volume have an histogram option?

@ilgizar
Copy link
Contributor Author

ilgizar commented Feb 20, 2018

@JamesGalt Thanx.
How do you imagine overlaying a histogram on a time series? Grafana natively does not yet support the second x-axis.
PS: although in my plugin I can add one more x-axis (to top or bottom).

@JamesGalt
Copy link

@ilgizar Sorry, by histogram I was meaning bar view.
But histogram can be an idea for price repartition. Not sure how useful id would be.
Again, Thanks!

@ilgizar
Copy link
Contributor Author

ilgizar commented Feb 21, 2018

I moved flot candlestick plugin inside to panel grafana plugin.
@JamesGalt beta version was placed here https://github.com/ilgizar/ilgizar-candlestick-panel/raw/master/pack/ilgizar-candlestick-panel.zip

@ilgizar ilgizar closed this Feb 21, 2018
@JamesGalt
Copy link

@ilgizar Brillant!
First impressions:
I dont know why but boxes are two wide
see screenshot
capture d ecran 2018-02-22 a 00 55 20

which version of grafana are you using? thanks

@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Candlestick charts for histograms
4 participants