Skip to content

Commit

Permalink
make the memory leak bug clearer
Browse files Browse the repository at this point in the history
see #50
  • Loading branch information
Dieterbe committed Mar 23, 2017
1 parent ccff6a2 commit 70f1779
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Limitations

* regex rewriter rules do not support limiting number of replacements, max must be set to -1
* the web UI is not always reliable to make changes. the config file and tcp interface are safer and more complete anyway.
* internal metrics *must* be routed somewhere (e.g. into the relay itself) otherwise it'll [leak memory](https://github.com/graphite-ng/carbon-relay-ng/issues/50).
this is a silly bug but I haven't had time yet to fix it.


Releases & versions
Expand Down
7 changes: 5 additions & 2 deletions examples/carbon-relay-ng-docker.ini
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ init = [
]

[instrumentation]
# in addition to serving internal metrics via expvar, you can optionally send em to graphite
graphite_addr = "localhost:2003" # feed back into the relay itself
# in addition to serving internal metrics via expvar, you can send them to graphite/carbon
# IMPORTANT: setting this to "" will disable flushing, and metrics will pile up and lead to OOM
# see https://github.com/graphite-ng/carbon-relay-ng/issues/50
# so for now you MUST send them somewhere. sorry.
graphite_addr = "localhost:2003"
graphite_interval = 1000 # in ms
7 changes: 5 additions & 2 deletions examples/carbon-relay-ng.ini
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ amqp_vhost = "/graphite"
amqp_exchange = "metrics"

[instrumentation]
# in addition to serving internal metrics via expvar, you can optionally send em to graphite
graphite_addr = "" # localhost:2003 (how about feeding back into the relay itself? :)
# in addition to serving internal metrics via expvar, you can send them to graphite/carbon
# IMPORTANT: setting this to "" will disable flushing, and metrics will pile up and lead to OOM
# see https://github.com/graphite-ng/carbon-relay-ng/issues/50
# so for now you MUST send them somewhere. sorry.
graphite_addr = "localhost:2003"
graphite_interval = 1000 # in ms

0 comments on commit 70f1779

Please sign in to comment.