Authn: Add common wrappers for identity and access tokens #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also validate that the token is of correct type
kalleep
commented
Apr 2, 2024
kalleep
commented
Apr 2, 2024
cinaglia
reviewed
Apr 5, 2024
Co-authored-by: Victor Cinaglia <victorcinaglia@gmail.com>
Co-authored-by: Victor Cinaglia <victorcinaglia@gmail.com>
|
@cinaglia I refactor it quite a lot, now they are truly just convenient wrappers for access token and id token. They Instead return expected claims, so not doing anything with the audience. I also moved the type to creation. I was thinking of adding it to config first but not sure it is needed from there. They annoying thing will be to sync these claims when we do changes. But the alternative would be that everyone that uses Verifier directly would have to do it themself. If these wrappers are used it would be done by upgrading the package |
kalleep
commented
Apr 5, 2024
| @@ -7,12 +7,12 @@ import ( | |||
| "github.com/go-jose/go-jose/v3/jwt" | |||
| ) | |||
|
|
|||
| type IDVerifierConfig struct { | |||
| type VerifierConfig struct { | |||
There was a problem hiding this comment.
This is not really IDVerifierConfig, we can use this for other things like access tokens
3 tasks
Co-authored-by: Victor Cinaglia <victorcinaglia@gmail.com>
Co-authored-by: Victor Cinaglia <victorcinaglia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add two wrappers around verifier with common use-cases we have.
One wrapper for extrating and validating grafana id tokens and one for access tokens. I also break the api on verify to include the expected typ of the token. We use
at+jwtfor access tokens andjwtfor id tokens.