Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Declarative DSL runtime setting properties in Kotlin types #28569

Merged
merged 1 commit into from Mar 26, 2024

Conversation

h0tk3y
Copy link
Member

@h0tk3y h0tk3y commented Mar 25, 2024

If Kotlin reflection cannot find the property or the setter method, try to look up the setter via Java reflection.

Also, refactor some code around DeclarativeRuntimeProperty.

Fixes https://github.com/gradle/gradle-private/issues/4160

If Kotlin reflection cannot find the property or the setter method,
try to look up the setter via Java reflection.

Also, refactor some code around `DeclarativeRuntimeProperty`.
@h0tk3y h0tk3y self-assigned this Mar 25, 2024
@h0tk3y h0tk3y requested a review from a team as a code owner March 25, 2024 17:35
@h0tk3y h0tk3y requested a review from eskatos March 25, 2024 17:35
@h0tk3y
Copy link
Member Author

h0tk3y commented Mar 25, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the refactoring clearly separating read/write operations

@h0tk3y h0tk3y added this pull request to the merge queue Mar 26, 2024
@bot-gradle bot-gradle added this to the 8.8 RC1 milestone Mar 26, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has started. Click here to see all failures if any.

Merged via the queue into master with commit 0f3cf9d Mar 26, 2024
54 checks passed
@h0tk3y h0tk3y deleted the sigushkin/declarative-dsl/fix-set-on-kotlin-types branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants