Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using project dependencies in the declarative DSL with DependencyCollector #28465

Merged

Conversation

tresat
Copy link
Member

@tresat tresat commented Mar 14, 2024

This is pairing work done with @eskatos when attempting to convert additional subprojects in Now In Android.

It is necessary for gradle/nowinandroid#5.

@tresat tresat self-assigned this Mar 14, 2024
@tresat tresat added this to the 8.8 RC1 milestone Mar 14, 2024
@tresat tresat marked this pull request as ready for review March 14, 2024 18:43
@tresat tresat requested a review from a team as a code owner March 14, 2024 18:43
@tresat tresat requested a review from h0tk3y March 14, 2024 18:44
Copy link

gitstream-cm bot commented Mar 14, 2024

🥷 Code experts: h0tk3y, jbartok

tresat, jbartok have most 👩‍💻 activity in the files.
h0tk3y, tresat have most 🧠 knowledge in the files.

See details

platforms/core-configuration/declarative-dsl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/project/dependencyConfigurationSchema.kt

Activity based on git-commit:

tresat jbartok
MAR 7 additions & 7 deletions
FEB 137 additions & 65 deletions 113 additions & 13 deletions
JAN
DEC
NOV
OCT

Knowledge based on git-blame:
h0tk3y: 49%
tresat: 39%

To learn more about /:\ gitStream - Visit our Docs

Copy link
Member

@h0tk3y h0tk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 overall, see some ideas of improvements.

@tresat
Copy link
Member Author

tresat commented Mar 26, 2024

@bot-gradle test and merge

@bot-gradle bot-gradle added this pull request to the merge queue Mar 26, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has started. Click here to see all failures if any.

Merged via the queue into master with commit 464c82f Mar 26, 2024
21 checks passed
@bot-gradle bot-gradle deleted the tt/88/support-project-dependencies-in-declarative-dsl branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants